Allow disabling printing in wait_for_tx
#3782
Open
+44
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 3, 2025
cptartur
requested review from
franciszekjob and
MKowalski8
and removed request for
a team
cptartur
force-pushed
the
spr/master/94945a36
branch
from
3302850 to
899b363
Compare
cptartur
force-pushed
the
spr/master/e1eef354
branch
from
73fe359 to
cbc0c1d
Compare
cptartur
force-pushed
the
spr/master/94945a36
branch
from
899b363 to
a9c96f6
Compare
crates/sncast/src/lib.rs
Outdated
| provider, | ||
| transaction_hash, | ||
| wait_config.wait_params, | ||
| if wait_config.silent { None } else { Some(ui) }, |
There was a problem hiding this comment.
nit:
Suggested change
| if wait_config.silent { None } else { Some(ui) }, | |
| (!wait_config.silent).then(|| ui), |
There was a problem hiding this comment.
Don't think that's more readable, especially having to call the method on (!...)
There was a problem hiding this comment.
After changing the name to show_ui_outputs it makes sense now to modify it to wait_config.show_ui_outputs.then(|| ui)
cptartur
force-pushed
the
spr/master/e1eef354
branch
from
cbc0c1d to
be263c2
Compare
cptartur
force-pushed
the
spr/master/94945a36
branch
from
a9c96f6 to
41b8753
Compare
franciszekjob
approved these changes
Oct 6, 2025
cptartur
force-pushed
the
spr/master/94945a36
branch
from
41b8753 to
39b967c
Compare
cptartur
force-pushed
the
spr/master/e1eef354
branch
from
be263c2 to
0fd8433
Compare
cptartur
force-pushed
the
spr/master/94945a36
branch
from
39b967c to
0b18bd5
Compare
cptartur
force-pushed
the
spr/master/e1eef354
branch
from
0fd8433 to
40ad69c
Compare
cptartur
force-pushed
the
spr/master/94945a36
branch
from
0b18bd5 to
04e89a1
Compare
cptartur
force-pushed
the
spr/master/e1eef354
branch
from
40ad69c to
562b35d
Compare
commit-id:94945a36
cptartur
force-pushed
the
spr/master/94945a36
branch
from
04e89a1 to
5ea3fa5
Compare
ddoktorski
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
wait_for_tx#3782 ⬅